On 03/21/2012 05:21 PM, Rolf Eike Beer wrote:
> Am Dienstag 20 März 2012, 20:47:56 schrieb michaelc@xxxxxxxxxxx:
>> From: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>
>>
>> Signed-off-by: Minh Tran <MinhDuc.Tran@xxxxxxxxxx>
>> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>
>> Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
>> ---
>> drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c
>> b/drivers/scsi/be2iscsi/be_iscsi.c index 33c8f09..2bb681e 100644
>> --- a/drivers/scsi/be2iscsi/be_iscsi.c
>> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
>> @@ -221,7 +221,7 @@ int beiscsi_ep_get_param(struct iscsi_endpoint *ep,
>> struct beiscsi_endpoint *beiscsi_ep = ep->dd_data;
>> int len = 0;
>>
>> - SE_DEBUG(DBG_LVL_8, "In beiscsi_conn_get_param, param= %d\n", param);
>> + SE_DEBUG(DBG_LVL_8, "In beiscsi_ep_get_param, param= %d\n", param);
>>
>> switch (param) {
>> case ISCSI_PARAM_CONN_PORT:
>
> What about:
>
> SE_DEBUG(DBG_LVL_8, "In %s, param= %d\n", __func__, param);
>
Right now the rest of the driver does it the way in the patch, so that
is why I kept the current style. In another patch I was going to go
through the driver and modify the SE_DEBUG DBG_LEVEL stuff so that it
did what you suggest for all functions. The patchset was getting large
so I wanted to get the fix done, then do the major change that modifies
all logging in another patch in the next set.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
