> + */ > +int transport_handle_cdb_direct( > + struct se_cmd *cmd) > +{ > + if (!cmd->se_lun) { > + dump_stack(); > + printk(KERN_ERR "cmd->se_lun is NULL\n"); > + return -EINVAL; > + } > + if (in_interrupt()) { > + dump_stack(); > + printk(KERN_ERR "transport_generic_handle_cdb cannot be called" > + " from interrupt context\n"); > + return -EINVAL; > + } > + > + return transport_generic_new_cmd(cmd); I can't really see any reason to add this helper. It just adds rather pointless debug checks for cases that already will blow up "properly" with the current code. Let's keep the callchain lean and just leave it out. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html