From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Hi again Andy and Christoph,
These are two additional patches I am pushing into lio-core-2.6.git/master
for LIO v4.1 to properly enable the RX side direct queueing optimization with
iSCSI READs and non immediate iSCSI WRITE payloads. Note the logic to enable
this for all cases was not merged originally in Patch #39 from Andy's series.
So for the moment in Patch #1, the optimization has been added as a seperate
new caller: transport_handle_cdb_direct(), and transport_generic_handle_cdb() has
been left as-is for existing fabric code (namely tcm_fc, ib_srpt and ibmvscsis)
that have not tested with these changes so far.
The other changes in Patch #2 are specific to iscsi-target for enabling
transport_handle_cdb_direct() usage. This involves converting to a sleeping
sess->cmdsn_mutex for protecting the session wide CmdSN list in the path:
iscsit_sequence_cmd() ->
iscsit_execute_cmd() ->
transport_handle_cdb_direct() ->
transport_generic_new_cmd()
This is required because iscsit_execute_cmd() is being called with the CmdSN
lock held, and spinning here was causing issues during testing as we may
end up sleeping inside of transport_generic_new_cmd() while performing
allocations in transport_new_cmd_obj() -> transport_allocate_tasks().
Please have a look,
Thanks!
--nab
Nicholas Bellinger (2):
target: Add transport_handle_cdb_direct optimization
iscsi-target: Convert to cmdsn_mutex and transport_handle_cdb_direct
usage
drivers/target/iscsi/iscsi_target_core.h | 2 +-
drivers/target/iscsi/iscsi_target_device.c | 4 ++--
drivers/target/iscsi/iscsi_target_erl1.c | 18 +++++++++---------
drivers/target/iscsi/iscsi_target_erl2.c | 4 ++--
drivers/target/iscsi/iscsi_target_login.c | 2 +-
drivers/target/iscsi/iscsi_target_nego.c | 4 ++--
drivers/target/iscsi/iscsi_target_util.c | 4 ++--
drivers/target/target_core_transport.c | 24 ++++++++++++++++++++++++
include/target/target_core_transport.h | 1 +
9 files changed, 44 insertions(+), 19 deletions(-)
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
