On Fri, Jun 03, 2011 at 06:18:15PM -0700, Nicholas A. Bellinger wrote: > + ret = transport_generic_new_cmd(&cmd->se_cmd); > + if ((ret < 0) || (SE_CMD(cmd)->se_cmd_flags & SCF_SE_CMD_FAILED)) { No need for the inner braces. Also SCF_SE_CMD_FAILED won't ever be set if you call transport_generic_new_cmd, so no need to check it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html