On Mon, Feb 14, 2011 at 10:11 AM, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Mon, 14 Feb 2011 08:16:45 +0100 > Bart Van Assche <bvanassche@xxxxxxx> wrote: > >> Are you sure that it is fine to pass values like MSG_SIMPLE_TAG as the >> sixth argument of transport_init_se_cmd() ? As far as I know TCM >> doesn' t support any of the MSG_..._TAG values. > > Oops, I'll send the next version soon. Hi Tomo, Two other issues I noticed are: - send_rsp() sends back an SRP response with req_lim_delta = 1 before srp_iu_put() is invoked. I think this is a race condition: it can happen that the SRP initiator has received an SRP_RSP and sends a new SRP_CMD before srp_iu_put() was invoked. On a heavily loaded system that can trigger a queue overflow in the target. - As anyone can see in the driver code (and as specified in the PAPR) management datagrams (MADs) fall outside the SRP credit mechanism. Hence not reserving one credit (assuming that the initiator makes sure there is at most one outstanding MAD) for MAD can - at least in theory - trigger a queue overflow. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
