Re: [PATCH 3/3] tcm ibmvscsis driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 10, 2011 at 1:21 PM, FUJITA Tomonori
<fujita.tomonori@xxxxxxxxxxxxx> wrote:
> +       switch (cmd->task_attr) {
> +       case SRP_SIMPLE_TASK:
> +               attr = MSG_SIMPLE_TAG;
> +               break;
> +       case SRP_ORDERED_TASK:
> +               attr = MSG_ORDERED_TAG;
> +               break;
> +       case SRP_HEAD_TASK:
> +               attr = MSG_HEAD_TAG;
> +               break;
> +       default:
> +               printk(KERN_WARNING "Task attribute %d not supported\n",
> +                      cmd->task_attr);
> +               attr = MSG_SIMPLE_TAG;
> +       }
> +
> +       data_len = srp_data_length(cmd, srp_cmd_direction(cmd));
> +
> +       se_cmd = &vsc->se_cmd;
> +
> +       transport_init_se_cmd(se_cmd,
> +                             adapter->se_tpg.se_tpg_tfo,
> +                             adapter->se_sess, data_len,
> +                             srp_cmd_direction(cmd),
> +                             attr, vsc->sense_buf);

Hi Tomo,

Are you sure that it is fine to pass values like MSG_SIMPLE_TAG as the
sixth argument of transport_init_se_cmd() ? As far as I know TCM
doesn' t support any of the MSG_..._TAG values.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux