Thanks Jack, comments below:
On Sun, Feb 6, 2011 at 11:58 PM, jack_wang <jack_wang@xxxxxxxxx> wrote:
>
> +
> + /**
> + * check interrupt_handler's status and call completion_handler if true,
> + * link_up events should be coming from the scu core lib, as phy's come
> + * online. for each link_up from the core, call
> + * get_received_identify_address_frame, copy the frame into the
> + * sas_phy object and call libsas notify_port_event(PORTE_BYTES_DMAED).
> + * continue to return zero from thee scan_finished routine until
>
> [Jack] Here "thee" seams typo of "the"
Yes, fixed.
> + /* memset the whole memory area. */
> + memset((char *)uncached_address, 0, size);
> [Jack] cast void * is not needed.
Yes, and neither is the comment.
> + struct sci_physical_memory_descriptor *mde_struct,
> + struct coherent_memory_info *mdl_struct)
> +{
> + unsigned long address = 0;
> + dma_addr_t dma_addr = 0;
> +
> + address = (unsigned long)mdl_struct->vaddr;
> [Jack] Why cast void vadd to usigned long? This may cause problem on x64.
No, Linux is LP64. However this routine does not seem to be aware of
the fact that dma_alloc_coherent always returns at least page
alignment, and also open codes the ALIGN() macro.
> + /* stop the comtroller and wait for completion. */
> [Jack] controller.
Yes, misspelled and superfluous given the context... deleted.
> +static inline struct isci_pci_info *to_pci_info(struct pci_dev *pdev)
> +{
> + return pci_get_drvdata(pdev);
> +}
> +
> [Jack] This wrap is not needed I think.
Ok, fixed up all occurrences of unnecessary line wrapping in host.h.
> +static inline
> +enum isci_status isci_host_get_state(
> + struct isci_host *isci_host)
> +{
> + return isci_host->status;
> +}
> [Jack] This wrap is not needed too.
This helper is not needed. Will remove.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
