On 02/12/2011 05:30 PM, James Bottomley wrote: > On Fri, 2011-01-21 at 09:07 +0100, Hannes Reinecke wrote: >> Consider a scenario where a SCSI EH command like TUR fails with a NOT READY >> status - MANUAL INTERVENTION REQUIRED (02/04/03). As evident in the ASC/ASCQ >> description, manual intervention is required in this case i.e. the target wants >> TUR to fail here so that the host administrator can take corrective action. >> >> But this particular ASC/ASCQ is not handled in the scsi_check_sense, which >> ultimately causes scsi_eh_tur to erroneously report a SUCCESS (device ready) >> instead of the actual FAILURE state (device not ready). >> >> This patch converts scsi_check_sense() to return SOFT_ERROR in >> cases where an error has been signalled via the sense code, but >> we should not wake the error handler. This error code will be >> reverted back to SUCCESS for normal command handling, but >> scsi_eh_completed_normally() will convert it to FAILED. > > I can't reconcile this patch with the detailed error handling ones: you > change a lot of call sites to TARGET_ERROR in that patch and SOFT_ERROR > in this one. Since the detailed error handling seems the more > important, I'll drop this one ... can you work out a reconciliation, > please? > Yes. I'm in discussion with NetApp (as the original reporter) about details about this patch anyway. I'll be sending an update. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg GF: Markus Rex, HRB 16746 (AG NÃrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
