On Mon, 2010-12-20 at 18:36 -0600, Mike Christie wrote: > On 12/20/2010 03:30 AM, Nicholas A. Bellinger wrote: > > After a quick audit of iscsi_session->lock usage, and I see that > > iscsi_complete_pdu(), iscsi_tmf_timedout(), iscsi_eh_cmd_timed_out(), > > iscsi_check_transport_timeouts() are using spin_lock(), and > > iscsi_session_failure() and iscsi_conn_failure() are using > > spin_lock_irqsave(). > > > > Mike and Hannes, would you guys mind commenting on this..? From what I > > can determine these should all be converted to use spin_lock_bh(), > > yes..? > > > > Yeah, they can use _bh locking. I was going to use them for qla4xxx eh, > which does iscsi processing in its irq, but we never did. Thanks for the clarification. I would be happy to submit a patch next week for this seperately from the host_lock-less conversion pieces, or would you prefer handle this yourself..? Best Regards, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
