On 10/20/2010 06:04 PM, Joe Eykholt wrote:
#ifndef __BIGENDIAN
-#define bfa_os_hton3b(_x) bfa_swap_3b(_x)
+#define bfa_os_hton3b(_x) bfa_swap_3b(_x)
Should bfa_os_hton3b and related functionality be relocated
appropriately and implemented in common form to the other common byte
swapping code?
Yes. I think intel was working on that for fcoe. Someone should dig up the patches and finish pushing.
It's in<scsi/fc_frame.h> as hton24() / ntoh24(). It's written in
an endian-independent way. I don't know of patches to move them to
a better place.
iscsi and some other code has it too. Chris Leech was working on it in
this patchset "24-bit types: typedef and functions for accessing 3-byte
arrays as integers". I think this was the latest:
http://www.mail-archive.com/jfs-discussion@xxxxxxxxxxxxxxxxxxxxx/msg01330.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html