On 10/20/10 3:16 PM, Mike Christie wrote: > On 10/20/2010 10:25 AM, Rob Evers wrote: >> Is scsi_for_each_sg() use pretty standard for mass storage drivers these >> days? > > Yes, the driver should be using it. > >> >> Is the byte swapping required if the more traditional sg implementation >> is used? >> >>> >>> #ifndef __BIGENDIAN >>> -#define bfa_os_hton3b(_x) bfa_swap_3b(_x) >>> +#define bfa_os_hton3b(_x) bfa_swap_3b(_x) >> >> Should bfa_os_hton3b and related functionality be relocated >> appropriately and implemented in common form to the other common byte >> swapping code? >> > > Yes. I think intel was working on that for fcoe. Someone should dig up the patches and finish pushing. It's in <scsi/fc_frame.h> as hton24() / ntoh24(). It's written in an endian-independent way. I don't know of patches to move them to a better place. Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
