>On 10/20/2010 10:25 AM, Rob Evers wrote: >> Is scsi_for_each_sg() use pretty standard for mass storage drivers these >> days? > >Yes, the driver should be using it. > We are not using the scsi_for_each_sg because currently we setup the scsi data buffers in two separate steps. The reason of doing that is we allow one buffer being inlined in the IO request, while the remaining buffers in sg pages. The sg elements in the IO request and sgpg have different format per ASIC spec, we hence think It is logically clearer to set them up in two different functions. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html