On Wed, Jul 28, 2010 at 11:28:59AM +0200, Christoph Hellwig wrote: > If we move all filesystems to non-draining barriers with pre- and post- > flushes that might actually be a relatively easy first step. We don't > have the complications to deal with multiple types of barriers to > start with, and it'll fix the issue for devices without volatile write > caches completely. > > I just need some help from the filesystem folks to determine if they > are safe with them. > > I know for sure that ext3 and xfs are from looking through them. And > I know reiserfs is if we make sure it doesn't hit the code path that > relies on it that is currently enabled by the barrier option. > > I'll just need more feedback from ext4, gfs2, btrfs and nilfs folks. > That already ends our small list of barrier supporting filesystems, and > possibly ocfs2, too - although the barrier implementation there seems > incomplete as it doesn't seem to flush caches in fsync. Define "are safe" --- what interface we planning on using for the non-draining barrier? At least for ext3, when we write the commit record using set_buffer_ordered(bh), it assumes that this will do a flush of all previous writes and that the commit will hit the disk before any subsequent writes are sent to the disk. So turning the write of a buffer head marked with set_buffered_ordered() into a FUA write would _not_ be safe for ext3. For ext4, if we don't use journal checksums, then we have the same requirements as ext3, and the same method of requesting it. If we do use journal checksums, what ext4 needs is a way of assuring that no writes after the commit are reordered with respect to the disk platter before the commit record --- but any of the writes before that, including the commit, and be reordered because we rely on the checksum in the commit record to know at replay time whether the last commit is valid or not. We do that right now by calling blkdev_issue_flush() with BLKDEF_IFL_WAIT after submitting the write of the commit block. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
