On Thu, Jul 29, 2010 at 09:54:50AM -0700, Joel Becker wrote: > handled-for-us behaviors of sync have changed. If the VFS is already > doing some work for us, maybe we don't need to do it. But we have to be > sure that these calls are always going through those paths. We sync our > files to disk when we drop cluster locks, regardless of whether there is > a userspace fsync(). ocfs2_sync_file only gets called through the fsync inode operation, so that doesn't happen here. And if it did the filemap_fdatawrite would not help at all, given that is only starts writeout, but never waits for it to finish. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html