On Fri, 2010-02-12 at 11:29 -0600, Mike Christie wrote:
> On 02/11/2010 05:08 AM, Ravi Anand wrote:
> > On Mon, 01 Feb 2010, Mike Christie wrote:
> >>
> >> On 01/30/2010 12:28 AM, Ravi Anand wrote:
> >>>
> >>> - msleep(2000);
> >>> - } while (max_wait_time--);
> >>> + if (got_ref&& (atomic_read(&rp->ref_count) == 1)) {
> >>> + done++;
> >>> + break;
> >>> + }
> >>> +
> >>> + msleep(ABORT_POLLING_PERIOD);
> >>
> >>
> >> Did you want to use krefs for the refcounting?
> >
> > We will add it to our to do list and submit a patch later on.
> > For right now we will like to stick to it as kref will require
> > additional testing.
> >
>
> Please use krefs from the start. Other drivers like beiscsi have had to
> switch from its own refcount code to krefs, and have had to retest their
> patchsets. You have to change your code in some other patches and maybe
> this one too, so you have to retest everything either way.
That goes for me too, please ... it's a standard kernel paradigm and all
the queries about what the refs were doing earlier would have been a lot
simpler since the embedded krefs would largely have answered the
questions.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
