Re: [PATCH 06/11] qla4xxx: added srb referance counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2010 05:08 AM, Ravi Anand wrote:
On Mon, 01 Feb 2010, Mike Christie wrote:

On 01/30/2010 12:28 AM, Ravi Anand wrote:

-		msleep(2000);
-	} while (max_wait_time--);
+		if (got_ref&&   (atomic_read(&rp->ref_count) == 1)) {
+			done++;
+			break;
+		}
+
+		msleep(ABORT_POLLING_PERIOD);


Did you want to use krefs for the refcounting?

We will add it to our to do list and submit a patch later on.
For right now we will like to stick to it as kref will require
additional testing.


Please use krefs from the start. Other drivers like beiscsi have had to switch from its own refcount code to krefs, and have had to retest their patchsets. You have to change your code in some other patches and maybe this one too, so you have to retest everything either way.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux