Hi Eike, On Tue, 2009-09-08 at 22:54 -0700, Rolf Eike Beer wrote: > Alok Kataria wrote: > > > +/* Command line parameters */ > > +static int pvscsi_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_PER_RING; > > +static int pvscsi_msg_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_MSG_RING; > > +static int pvscsi_cmd_per_lun = PVSCSI_DEFAULT_QUEUE_DEPTH; > > +static int pvscsi_disable_msi; > > +static int pvscsi_disable_msix; > > +static int pvscsi_use_msg = true; > > Should be bool. Yeah, could be done, though I think I will do this later as an incremental change or piggyback it if something else comes up. > > Do I get annoying? ;) :) Do you want the truth ? ;). Actually its good that the code is being reviewed in so much details. Thanks for your time on this. --Alok > > Eike -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
