On 09/08/2009 05:34 PM, Jayamohan Kalickal wrote:
> + max_size = ALIGN(sizeof(struct be_cmd_bhs), 64) * sess->cmds_max;
> + vaddr = pci_alloc_consistent(phba->pcidev,
Do you just want a dma/pci pool? It will align structs for you too, I think.
I didn't want to do it because we do not really alloc/free once a connection is established.
Yes, it can be done that way but certainly would not wan to do that in the IO hot path (even
if it picking from pool).
I was just going by some other drivers like lpfc where they create the
pool at pci probe time, then also preallocate from the pool at some
setup/init time. In the case of lpfc it allocates scsi bufs for each
command in its slave_alloc when new devices are added.
It is not a big deal. If people are ok with it as is, I am fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
