On Tue, 2009-09-08 at 18:15 -0700, Alok Kataria wrote:
> +typedef struct PVSCSIRingCmpDesc {
> + u64 context;
> + u64 dataLen;
> + u32 senseLen;
> + u16 hostStatus;
> + u16 scsiStatus;
> + u32 _pad[2];
> +} __packed PVSCSIRingCmpDesc;
I get a lot of checkpatch warnings due to the typedefs here.. They are
usually frowned upon, and it really does make you code look alien ..
> +#define PVSCSI_MEM_SPACE_COMMAND_PAGE 0
> +#define PVSCSI_MEM_SPACE_INTR_STATUS_PAGE 1
> +#define PVSCSI_MEM_SPACE_MISC_PAGE 2
> +#define PVSCSI_MEM_SPACE_KICK_IO_PAGE 4
> +#define PVSCSI_MEM_SPACE_MSIX_TABLE_PAGE 6
> +#define PVSCSI_MEM_SPACE_MSIX_PBA_PAGE 7
Why not use an enum for the above? Your using enums in the rest of your
code..
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
