>> + BUG_ON(rq->cmd_len != SCSI_EXT_CDB_SIZE); Boaz> This is not nice you check on the rq->cmd_len but proceed to use Boaz> the SCpnt->cmnd. Better ask for SCpnt->cmd_len, just for Boaz> consistency Well, I didn't actually mean to leave that BUG_ON in the hot path. In any case we won't get this far if the cmd_len is not 32. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html