>>>>> "Boaz" == Boaz Harrosh <bharrosh@xxxxxxxxxxx> writes: >> + *lba = (u64)cmd[19] | (u64)cmd[18] << 8 | >> + (u64)cmd[17] << 16 | (u64)cmd[16] << 24 | >> + (u64)cmd[15] << 32 | (u64)cmd[14] << 40 | >> + (u64)cmd[13] << 48 | (u64)cmd[12] << 56; Boaz> get_unaligned_be64() As you noticed further down in that patch I do generally use the get_unaligned_* macros in "my own" code. However, when I update somebody else's code I try to match the existing style. And in this case rest of get_data_transfer_info() is using explicit shifts and to me it looks absolutely horrendous to mix the two. I generally avoid mixing cleanups and new functionality. I don't have a problem with switching over to the macros, but in that case I think the whole function should be updated. And that should be an orthogonal patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
