>> + if (cmd->cmd_len == SCSI_EXT_CDB_SIZE) >> + mempool_free(cmd->cmnd, cdb_pool); >> + Boaz> This will not work. The cmd->cmnd might happen to be form an upper Boaz> layer through bsg or blk_execute_xxx and might just be Boaz> SCSI_EXT_CDB_SIZE. This patch has been kicking around in my tree for a while and it was a huge, gnarly mess. I trimmed it down a lot before sending it out yesterday and forgot why I originally had an allocation flag in scsi_cmnd. I think I'll reinstate that just to play it safe. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html