Hi Chandra, On Fri, Apr 03, 2009 at 03:43:10PM -0700, Chandra Seetharaman wrote: > Hi James, > > Do you still have any concerns (after Peter's response) ? > > If not, Can you accept the patches, please. > The problem here is that module autoloading doesn't work for device_handler. We have to have the callbacks in place _before_ driver probing starts as we might need to intercept the I/O requests and/or errors. When using modalias the module loading will be too late and the hooks will only be established after the probing has already happened. (The module autoloading is an asynchronous call in device_add(), where we don't write for it to succeed. So probing will continue and we woulnd't have the callbacks in place when probing starts). So adding the modalias will be of a purely informational value which I doubt is worth it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N�g GF: Markus Rex, HRB 16746 (AG N�g) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
