On Sat, 2009-04-04 at 15:15 +0530, Desai, Kashyap wrote:
> James,
>
> After creating patch, I usually run check_patch script available in scripts directory of linux source tree.
> Below changes are just to remove warning and error related to coding standards from generated patch.
Hmm, then we have an error in checkpatch.pl if it's saying that
x = y
if (x == NULL)
should become
if ((x = y) == NULL)
Can you attach the warning so I can get the checkpatch maintainers to
explain what's going on?
Thanks,
James
> If you suggest, not to have those changes merge with actual logical
> patch then please let me know. I can rework and resubmit.
>
>
> Thanks
> Kashyap
> ________________________________________
> From: James Bottomley [James.Bottomley@xxxxxxxxxxxxxxxxxxxxx]
> Sent: Friday, April 03, 2009 1:38 PM
> To: Desai, Kashyap
> Cc: linux-scsi@xxxxxxxxxxxxxxx; Moore, Eric; Prakash, Sathya
> Subject: Re: [PATCH 1/6] mpt fusion: fix for previous patch taskmgmt in progress should be cleared before return
>
> On Fri, 2009-04-03 at 17:19 +0530, Kashyap, Desai wrote:
> > -
> > - mf = mpt_get_msg_frame(mptsasDeviceResetCtx, ioc);
> > - if (mf == NULL) {
> > + if ((mf = mpt_get_msg_frame(mptsasDeviceResetCtx, ioc)) == NULL) {
> > dfailprintk(ioc, printk(MYIOC_s_WARN_FMT
>
> This is making a clear statement (assignment then check) less clear for
> no practical purpose that I can see.
>
> James
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
