Re: [PATCH 1/6] mpt fusion: fix for previous patch taskmgmt in progress should be cleared before return

[James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>]

On Fri, 2009-04-03 at 17:19 +0530, Kashyap, Desai wrote:
> -
> -       mf = mpt_get_msg_frame(mptsasDeviceResetCtx, ioc);
> -       if (mf == NULL) {
> +       if ((mf = mpt_get_msg_frame(mptsasDeviceResetCtx, ioc)) == NULL) {
>                 dfailprintk(ioc, printk(MYIOC_s_WARN_FMT

This is making a clear statement (assignment then check) less clear for
no practical purpose that I can see.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html