On Fri, 2009-03-27 at 09:09 -0600, Matthew Wilcox wrote: > On Thu, Mar 26, 2009 at 03:54:09PM -0500, James Bottomley wrote: > > Also (as Randy pointed out) you don't account for the domain. However, > > you could just by not bothering to convert the string to numbers for the > > compare, just compare on dev->bus_id ... which is how a generic one > > would work. > > I think it needs to be PCI and not device core. bus_id isn't guaranteed > to be unique between different bus types. I don't know of any that > conflict, but we don't want to inadvertently disable, say, an SBUS > device while trying to disable a PCI device. Actually they better be ... we'll get into real trouble if they're not because of the way we flatten the space for multiple bus binding drivers. Even if I accepted your argument, I still can't see why we'd only implement this for PCI, and thus why it shouldn't be in the generic device part (except possibly with a bus type name qualifier). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
