On Thu, Mar 26, 2009 at 03:54:09PM -0500, James Bottomley wrote: > Also (as Randy pointed out) you don't account for the domain. However, > you could just by not bothering to convert the string to numbers for the > compare, just compare on dev->bus_id ... which is how a generic one > would work. I think it needs to be PCI and not device core. bus_id isn't guaranteed to be unique between different bus types. I don't know of any that conflict, but we don't want to inadvertently disable, say, an SBUS device while trying to disable a PCI device. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html