Jens Axboe wrote: > On Thu, Mar 19 2009, Boaz Harrosh wrote: >> Put a WARN_ON in __blk_put_request if it is about to >> leak bio(s). This is a serious bug that can happen in error >> handling code paths. >> >> For this to work I have fixed a couple of places in block/ where >> request->bio != NULL ownership was not honored. And a small cleanup >> at sg_io() while at it. > > Ho humm, not sure what to do about this. Honestly, in all the time that > I have been doing this, this would have found about zero bugs. And now > enforces a rule that ->bio must be cleared. Normal bio completion does > that automatically, so it's not a problem there, but it's still a new > rule just to satisfy this questionable debug mechanism. > > But what the hell, it's simple enough. Kill the totally unrelated > scsi_ioctl.c change, and I'll toss it in for a spin. > The scsi_ioctl.c is related. It sets req->bio back from some internal held value just to carry it across a static function call, all the while when the function is not needed, totally bogus in the error handling check of an hard-coded 0, and a call sight that is bigger then the actual function. So it was better to fix it then, go around the problem of the code putting some private data on req->bio. I thought the all patch is worth it just for that bit Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
