On Thu, Mar 19 2009, Boaz Harrosh wrote: > > Put a WARN_ON in __blk_put_request if it is about to > leak bio(s). This is a serious bug that can happen in error > handling code paths. > > For this to work I have fixed a couple of places in block/ where > request->bio != NULL ownership was not honored. And a small cleanup > at sg_io() while at it. Ho humm, not sure what to do about this. Honestly, in all the time that I have been doing this, this would have found about zero bugs. And now enforces a rule that ->bio must be cleared. Normal bio completion does that automatically, so it's not a problem there, but it's still a new rule just to satisfy this questionable debug mechanism. But what the hell, it's simple enough. Kill the totally unrelated scsi_ioctl.c change, and I'll toss it in for a spin. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
