On Fri, 27 Feb 2009 21:50:14 -0700 Matthew Wilcox <matthew@xxxxxx> wrote: > On Fri, Feb 27, 2009 at 11:13:03PM -0500, Martin K. Petersen wrote: > > The following patch below sits somewhere between my original take and > > your patch. Those transports that have classes implemented fill out the > > id like you did. The ones that don't (ATA, FireWire and USB) set it > > manually. Best of both worlds, IMHO. > > You seem to have missed the patch to scsi_transport_spi.c. > There's also a lot of parallel SCSI drivers that don't use > scsi_transport_spi.c yet. I'm OK with them being 'unknown' and > eventually people patching them (or perhaps better, converting them to > use scsi_transport_spi!), but thought it was worth mentioning. Yeah, that's why my patch sets SCSI_TRANSPORT_SPI to 0. So a lot of parallel SCSI drivers that don't use spi class can get 'spi' properly. It's better to convert them to use spi class but I really doubt someone would do. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
