On Fri, 2008-11-07 at 11:22 -0500, Ric Wheeler wrote: > James Bottomley wrote: > >> Just testing it would be a fairly large challenge, spread out across N > >> filesystems. I think we need to keep discard as simple as we possibly > >> can. > >> > > I don't disagree with that ... I'm not saying we *should* merely that we > > *could*. > > > I agree that simple and robust are key, but we will need to try and do > reasonable coalescing of the requests. > > Depending on how vendors implement those unmap commands, sending down a > sequence of commands might cause a performance issue if done at too fine > a granularity. Easiest way to handle that is to make sure that we have a > way of disabling the unmap/discard support (mount option?). I'd really think not. The best way to handle this is through the block options. We'd give an interface to allow the user to change the defaults (i.e. turn off discard on a discard supporting device but not vice versa). Providing every possible block option as a mount option is asking for confused users. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
