On Fri, 2008-11-07 at 13:05 +0100, Jens Axboe wrote: > > >I skimmed it but don't see any update implying that trim might be > > >ineffective if we align wrongly ... where is this? > > > > I think we should be content to declare such devices 'broken'. > > > > They have to keep track of individual sectors _anyway_, and dropping > > information for small discard requests is just careless. > > I agree, seems pretty pointless. Lets let evolution take care of this > issue. I have to say I'm surprised that it really IS an issue to begin > with, are array firmwares really that silly? > > It's not that it would be hard to support (and it would eliminate the > need to do discard merging in the block layer), but it seems like one of > those things that will be of little use in even in the near future. > Discard merging should be useful, I have no problem merging something > like that. > Hmmm, it's surprising to me that arrays who tell us please use the noop elevator suddenly want us to merge discard requests. The array really needs to be able to deal with this internally. Not that discard merging is bad, but I agree that we need to push this problem off on the array vendors. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
