On Tue, 2008-10-07 at 17:28 -0600, Matthew Wilcox wrote: > On Tue, Oct 07, 2008 at 02:53:11PM -0700, Harvey Harrison wrote: > > In addition, there are some subsystems (scsi) that are looking into some > > differently sized endian helpers (be24) and it may be worthwhile to have > > some agreement whether it is worth making them common infrastructure and > > whether they should present a similar API to the common byteorder/unaligned > > API. > > I still think SCSI should have its own accessors, even if they're > just wrappers around the common BE code. > I thought it was generally discouraged that subsystems have trivial wrappers like that, otherwise you wind up with: scsi_get_u32 usb_get_u32 v4l_get_u32 ... and so on, where as if they all used the common names, people more used to other areas of the kernel can still recognize what the code is doing without having the lookup another define. Just my 2 cents Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
