Re: [PATCH] Fixup KERN_INFO in tmscsim.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guennadi,

On Sun, 17 Aug 2008 00:00:44 +0200 (CEST)
Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:

> From: Nick Warne <nick@xxxxxxxxx>
> 
> Multiline kernel messages should contain a priority in every line, 
> besides, some log daemons represent a tabulator as "^I", fix both
> these issues.
> 
> Signed-off-by: Nick Warne <nick@xxxxxxxxx>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

> Nick, I took the liberty to reformat your Sob and to replace the tab
> in your patch with spaces - as was in my previous reply to you. Hope,
> you don't mind:-)

No not at all - I saw just as I clicked *send* I buggered up the
Signed-off-by line... and also I didn't realise they was spaces - I
thought you changed to a real whitespace TAB rather than \t (but I
guess there is no difference on the way the lines get parsed).

Anyway, as an aside, my syslogd/klogd still shows whitespace TAB as ^I,
so I haven't clue what if going on there.

Also, now I have trimmed up my kernel build for new box, I don't see
these drivers anyway now... but at least it was caught.

Nick

> diff -u linux-2.6.26.y/drivers/scsi/tmscsim.cORIG
> linux-2.6.26.y/drivers/scsi/tmscsim.c ---
> linux-2.6.26.y/drivers/scsi/tmscsim.cORIG	2008-08-15
> 10:30:47.000000000 +0100 +++
> linux-2.6.26.y/drivers/scsi/tmscsim.c	2008-08-16
> 08:45:43.000000000 +0100 @@ -2573,8 +2573,8 @@ static int __init
> dc390_module_init(void) { if (!disable_clustering)
> -		printk(KERN_INFO "DC390: clustering now enabled by
> default. If you get problems load\n"
> -		       "\twith \"disable_clustering=1\" and report
> to maintainers\n");
> +		printk(KERN_INFO "DC390: clustering now enabled by
> default. If you get problems load\n");
> +		printk(KERN_INFO "       with
> \"disable_clustering=1\" and report to maintainers\n"); 
>  	if (tmscsim[0] == -1 || tmscsim[0] > 15) {
>  		tmscsim[0] = 7;
> 


-- 
Free Software Foundation Associate Member 5508
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux