On Fri, 15 Aug 2008, Nick Warne wrote: > Setting up my new AMD64 I noticed a curious one liner in syslogs: Wow, are you sure you need the tmscsim driver on your new amd64 system?:-) > ^Iwith "disable_clustering=1" and report to maintainers The message priority is indeed missing in the second line, but it has nothing to do with the "^I" in your log. I do not know why your syslogd / klogd converts a TAB to "^I". But if it is a problem, I think, the correct fix would be something like - printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n" - "\twith \"disable_clustering=1\" and report to maintainers\n"); + printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"); + printk(KERN_INFO " with \"disable_clustering=1\" and report to maintainers\n"); Or maybe just remove that printk altogether - it has been there for almost 2 years now, and I haven't heard a single complaint, but on the other hand, maybe you are the first, who at least loaded this driver since 2 years:-) Ok, taking into account that this driver is hardly used, I would keep this warning in case someone does get a problem. So, please, redo as above, create with "-p1" format, fix your Sob line > Signed off by: "Nick Warne" <nick@xxxxxxxxx> which has to be Signed-off-by: Nick Warne <nick@xxxxxxxxx> and send the patch inline, Thanks Guennadi --- Guennadi Liakhovetski -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
