On Wed, 2008-08-06 at 09:36 -0700, James Bottomley wrote: > On Wed, 2008-08-06 at 16:34 +0100, Hugh Dickins wrote: > > PQual=0 Device_type=0 RMB=1 version=0x00 [no conformance > > claimed] > > We could try using this as the trigger. I assume all DIF supporting > devices must also claim conformance to SPC3/SBC2 or higher? Just to formalise it, that would be this patch. Hugh, could you try it? Thanks, James --- diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 291d56a..ffbc84a 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -426,7 +426,7 @@ static inline int scsi_device_enclosure(struct scsi_device *sdev) static inline int scsi_device_protection(struct scsi_device *sdev) { - return sdev->inquiry[5] & (1<<0); + return sdev->scsi_level > SCSI_2 && sdev->inquiry[5] & (1<<0); } #define MODULE_ALIAS_SCSI_DEVICE(type) \ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html