On Thu, 31 Jul 2008 01:18:52 -0600 Matthew Wilcox <matthew@xxxxxx> wrote: > On Thu, Jul 31, 2008 at 01:55:31PM +0900, FUJITA Tomonori wrote: > > Someone might think that it would be better if we can change the > > filter without specifying all the accepted commands. For example, we > > could do like: > > > > clover:/sys/block/cciss!c0d0/cmd_filter# cat read_table > > 03 08 12 1a 1b 1c > > > > clover:/sys/block/cciss!c0d0/cmd_filter# echo 02 > read_table_on > > 02 03 08 12 1a 1b 1c > > > > But I don't have strong opinions about it. > > We need to be able to delete as well as add. Yeah, I thought about adding a new file such as read_table_off. > We could have a scheme in which: > > echo -- "-03" >read_table > cat read_table > 08 12 1a 1b 1c > > echo -- "+02 +07 +08" >read_table > cat read_table > 02 07 08 12 1a 1b 1c > > The + could be implicit. Looks another potential option though I prefer "-0x03" than "-03" as I said in the previous mail. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
