2008/7/28 FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>: >> > Thanks for the fixes, wanted to test them but they don't apply cleanly >> > here (tried against Jens and Linus tree). > > Hmm, I can cleanly apply them against Linus's latest tree: > > commit c9272c4f9fbe2087beb3392f526dc5b19efaa56b > Merge: fb4284b... 744d18d... > Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Date: Sun Jul 27 16:47:55 2008 -0700 > > Merge branch 'hotfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6 > > For your convenience, I also put them to a git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git cmdfilter > Odd, got them to build now from quick testing there seem to work fine. >> > Anyway the look fine to me from just reading it ... have you tested if >> > changing the filter actually works? >> > >> Should be "Anyway the look fine to me from just reading them ... have >> you tested if >> changing the filter (via sysfs) actually works?" > > Yes though not much. OK, thanks. Will do more detailed testing this weekend. > BTW, I think that we need a document about how to control command > filters via sysfs (and IMO, there might be a better interface to > change the filter). Yeah agreed, will add some docs this weekend. As for "better interface" ... I am open for suggestions ;) This was the one used in Peter's original patch and it looks straight forward. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html