>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Christoph> Nack. Creating of sd.h was a big mistake already and Christoph> should be reverse. No one but sd.c has any business Christoph> playing with these. DIF is part of SBC hence scsi_dif.c is a logical subset of sd.c. I could roll scsi_dif.c into sd.c but I don't necessarily think that's prettier. Maybe I should rename scsi_dif.c to sd_dif.c? An alternative to exporting scsi_disk() is to introduce a field in scsi_cmnd to let the HBA driver know how to handle the request. That's how I originally did it but didn't want to grow scsi_cmnd when I could avoid it. And it seemed DIF-specific. However, given the impending "I-can't-believe-it's-not-DIF" extensions for SCSI tape maybe there's merit in having a generic routing field? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
