On Sun, 30 Mar 2008 12:07:22 -0500 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 2008-03-28 at 14:48 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > powerpc: > > > > drivers/scsi/ips.c: In function 'ips_issue_copperhead': > > drivers/scsi/ips.c:5436: warning: large integer implicitly truncated to unsigned type > > > > it doesn't seem necessary to do outw(cpu_to_le32(...), ...) anyway. > > Actually, it's not only not necessary ... it's an actual bug on BE > platforms. Both writeX and outX/inX automatically convert from native > to bus endian (usually simply to LE since the bus is PCI). Therefore if > you add a cpu_to_leX, you actually write the wrong value on a BE system. > > Mark, it looks like the correct fix is simply to strip all of these ... > has this driver actually been tested on a BE platform (like parisc or > PPC)? I guess that it hasn't. ips.c includes: #if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__) #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" #endif -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
