Re: [patch 12/17] ips.c: fix build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-03-28 at 14:48 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
> powerpc:
> 
> drivers/scsi/ips.c: In function 'ips_issue_copperhead':
> drivers/scsi/ips.c:5436: warning: large integer implicitly truncated to unsigned type
> 
> it doesn't seem necessary to do outw(cpu_to_le32(...), ...) anyway.

Actually, it's not only not necessary ... it's an actual bug on BE
platforms.  Both writeX and outX/inX automatically convert from native
to bus endian (usually simply to LE since the bus is PCI).  Therefore if
you add a cpu_to_leX, you actually write the wrong value on a BE system.

Mark, it looks like the correct fix is simply to strip all of these ...
has this driver actually been tested on a BE platform (like parisc or
PPC)?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux