Re: [PATCH] 2.6.25-rc4-git3 - inquiry cmd issued via /dev/sg? device causes infinite loop in 2.6.24

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 Mar 2008 13:08:39 -0500
Mike Christie <michaelc@xxxxxxxxxxx> wrote:

> Michael Reed wrote:
> > -		++blk_size;	/* don't know why */
> > -/* round request up to next highest SG_SECTOR_SZ byte boundary */
> 
> I think we can remove this code. This was asked before, and here is 
> Doug's reply:
> http://www.mail-archive.com/linux-scsi@xxxxxxxxxxxxxxx/msg11757.html
> 
> It was probaly due to some weirdness in that the scatterlist that sg.c 
> made used to be sent directly to the LLD (now it is only used to 
> hold/organize the pages/segments that the sg and st driver manages in 
> their internal reserves), or maybe it had something to do with that and 
> dma alignment problems or something. I really have no idea, but the 
> block layer SG IO code has not been rounding up in its indirect path and 
> it has been fine.

The block layer (blk_rq_map_user) does padding for LLDs, I guess.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux