On Mon, 2008-02-11 at 09:17 -0800, Randy Dunlap wrote: > On Mon, 11 Feb 2008 09:08:05 -0800 Joe Perches wrote: > > > On Mon, 2008-02-11 at 09:30 -0600, James Bottomley wrote: > > > On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: > > > > - if (request_region(*base, 256, "aic7xxx") == 0) > > > > + if (!request_region(*base, 256, "aic7xxx")) > > > > > > This patch is completely pointless. > > > > It removes a sparse warning. > > I try to say that in the patch description. Andrew also tries > to enforce such errors/warnings in patch descriptions.... Well, the aic7xxx subdirectory is a nightmare of CodingStyle non conformities ... you can see the return (ENOMEM) just in this patch. That's two problems: the brackets and non negative error returns which are later converted to negative ones thus inviting sign problems. The driver is also about 3x bigger than it should be because of the vestiges of the BSD glue layer. However, I think my life is too short to apply the 32,554 patches it would take to correct this an issue at a time. This is one of those drivers we tolerate because we must and we fix up around the regions we have to touch. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
