On Mon, 2008-02-11 at 09:30 -0600, James Bottomley wrote: > On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: > > - if (request_region(*base, 256, "aic7xxx") == 0) > > + if (!request_region(*base, 256, "aic7xxx")) > > This patch is completely pointless. It removes a sparse warning. > There's a marginal preference for if (!x) over if (x == NULL) > for pointers, but it's still up to a driver writer if they wish to use > the marginally unpreferred form. Use == NULL then if you care to. cheers, Joe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html