On Fri, Oct 19, 2007 at 12:33:31PM -0600, Matthew Wilcox wrote:
>
> This fairly naive patch introduces alloc_cmnd and destroy_cmnd. I'm not
> exactly happy about passing down the gfp_mask -- I'd prefer to be able
> to allocate scsi_cmnds before we grab the queue_lock (and hence get
> rid of the possibility we might need to GFP_ATOMIC), but I don't see
> anywhere to do that. Maybe there's a simple change we can make to the
> block layer to allow it.
This looks fine to. It might be nice to factor the code out into
a few more helpers:
static struct scsi_cmnd *scsi_alloc_cmnd(struct Scsi_Host *shost, gfp_t mask)
{
if (shost->hostt->alloc_cmnd)
return shost->hostt->alloc_cmnd(shost, mask);
else
return kmem_cache_alloc(shost->cmd_pool->slab,
mask | shost->cmd_pool->gfp_mask);
}
static struct scsi_cmnd *scsi_destroy_cmnd(struct Scsi_Host *shost,
struct scsi_cmnd *cmd)
{
if (likely(cmd != NULL)) {
if (shost->hostt->destroy_cmnd)
shost->hostt->destroy_cmnd(cmd);
else
kmem_cache_free(shost->cmd_pool->slab, cmd);
}
}
plus helper to setup/teardown the pools if nessecary so that the code
flow is easier to read. Also maybe a s/destroy/free/. The VFS uses
destroy for inodes, but I'd personally prefer free.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
