On Tue, Oct 23, 2007 at 11:48:04AM -0600, Matthew Wilcox wrote: > On Tue, Oct 23, 2007 at 06:49:17PM +0200, Boaz Harrosh wrote: > > You know Matthew when you first talked about this, I envisioned > > something else. > > Right, so did I. Christoph felt that alloc_cmnd/destroy_cmnd a la the > VFS layer's alloc_inode/destroy_inode was a better route. I didn't have > a strong feeling, so I implemented that. Yeah. Let me repeat my rationale for the method here: If we only have a size member that means we can only allocate things using the slab allocator. But there's a variety of drivers requiring other allocations (e.g. pci_pool or the sym2 allocator) aswell, and having the methods means we can always have a pre-constructed command for those aswell, which makes these drivers deadlock-safe without much effort. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
