Matthew Wilcox wrote:
On Tue, Oct 02, 2007 at 10:28:29PM -0400, Jeff Garzik wrote:
Incorrect. That is highly platform specific, with many using unsigned
long, since the [non-x86] platform is generally pointing to a special
memory region rather than directly using an x86-like instruction.
unsigned long is the portable size to use, because it is guaranteed to
work on all platforms.
unsigned int means you exclude powerpc[64], alpha, sparc64, sh, ...
it's not portable, unlike unsigned long.
I don't think that's true. I asked a powerpc64 person about it the
other day, and he said they don't use anything beyond the lower 32 bits.
If people are really supposed to use unsigned long, it would make sense
to get the i386 macros changed, since they are canonical.
You're pushing against over a decade-long practice and moving into
NAK-land... This is the way portable drivers have always been written.
If you want to go against the grain, first change the architectures to
not use unsigned long. Until such time... you know what to do :)
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
