On Tue, Oct 02, 2007 at 10:00:18PM -0400, Jeff Garzik wrote: > Matthew Wilcox wrote: > >-#define PortAddr unsigned short /* port address size > >*/ > >+#define PortAddr unsigned int /* port address size > >*/ > > #define inp(port) inb(port) > > #define outp(port, byte) outb((byte), (port)) > > everybody just uses unsigned long these days... any reason using > unsigned long would be harmful? inb/outb use signed int for port addresses ... eventually, I'll flip this driver over to using iomap and it'll all be void __iomem *, but unsigned int felt right for ioports today. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
