Matthew Wilcox wrote:
On Tue, Oct 02, 2007 at 10:00:18PM -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
-#define PortAddr unsigned short /* port address size
*/
+#define PortAddr unsigned int /* port address size
*/
#define inp(port) inb(port)
#define outp(port, byte) outb((byte), (port))
everybody just uses unsigned long these days... any reason using
unsigned long would be harmful?
inb/outb use signed int for port addresses ...
Incorrect. That is highly platform specific, with many using unsigned
long, since the [non-x86] platform is generally pointing to a special
memory region rather than directly using an x86-like instruction.
unsigned long is the portable size to use, because it is guaranteed to
work on all platforms.
unsigned int means you exclude powerpc[64], alpha, sparc64, sh, ...
it's not portable, unlike unsigned long.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
