On Sun, 2024-06-23 at 19:03 +0530, manivannan.sadhasivam@xxxxxxxxxx wrote: > > > > > > Hi Bart and Mani, > > > > It is correct that 0x1F is SDB mode. > > ufshcd_mcq_decide_queue_depth is running before mcq enable. > > So that value read is still SDB value, not MCQ value. > > > > I don't quite understand. My concern was that if we change the mask > for MCQ, > then existing 'nutrs' value for SDB could be impacted with this > change. > > Perhaps we should use different masks? > > - Mani > Hi Mani, Yes, it is better use different mask with different mode. And we can only use 0xFF mask if 0x300[0] = 1 (MCQ enable) use 0x1F mask if 0x300[0] = 0 (Single doorbell mode) Mediatek design in MCQ mode is 64, Single doorbell mode is 32. Thanks. Peter
